-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: accounts for IgnoreMaxNamespace flag in the ProveNamespace method #194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 95.71% 95.41% -0.30%
==========================================
Files 5 5
Lines 560 567 +7
==========================================
+ Hits 536 541 +5
- Misses 14 15 +1
- Partials 10 11 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[no blocking feedback] but can't approve b/c I don't understand the test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding the following note for the future reference: The codecov has decreased since previously, there was a possibility of encountering an error in the |
Overview
Closes #159