refactor! Change ComputeExtendedDataSquare argument from TreeConstructorFn to string
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 80.76% 79.49% -1.27%
==========================================
Files 7 8 +1
Lines 806 839 +33
==========================================
+ Hits 651 667 +16
- Misses 112 123 +11
- Partials 43 49 +6 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 30, 2024
|
close this in favor of #287 |
rootulp
added a commit
that referenced
this pull request
Feb 2, 2024
Closes #286 by deleting `getTreeNameFromConstructorFn`. Closes #288, #289 by fixing those tests. Inspired by #278 Includes two breaking changes: 1. `ComputeExtendedDataSquare` now accepts a parameter `treeName: string` 2. `ImportExtendedDataSquare` now accepts a parameter `treeName: string` --------- Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
0xchainlover
pushed a commit
to celestia-org/rsmt2d
that referenced
this pull request
Aug 1, 2024
Closes celestiaorg/rsmt2d#286 by deleting `getTreeNameFromConstructorFn`. Closes celestiaorg/rsmt2d#288, celestiaorg/rsmt2d#289 by fixing those tests. Inspired by celestiaorg/rsmt2d#278 Includes two breaking changes: 1. `ComputeExtendedDataSquare` now accepts a parameter `treeName: string` 2. `ImportExtendedDataSquare` now accepts a parameter `treeName: string` --------- Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes
ComputeExtendedDataSquareTreeConstructorFntype argument to astringtype represent the treeNameChecklist