Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: node v0.7.0-rc9 adaptations #188

Merged
merged 2 commits into from
Feb 27, 2023
Merged

feat: node v0.7.0-rc9 adaptations #188

merged 2 commits into from
Feb 27, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Feb 24, 2023

Overview

To make testground tests compatible with latest arabica/robusta testnets

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 added test Request for creating a test-case testground related to testground labels Feb 24, 2023
@Bidon15 Bidon15 self-assigned this Feb 24, 2023
tty47
tty47 reviewed Feb 27, 2023
View reviewed changes
testkit/nodekit/node.go Outdated Show resolved Hide resolved
tty47
tty47 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Bidon15 Bidon15 merged commit 29e0293 into celestiaorg:main Feb 27, 2023
@Bidon15 Bidon15 mentioned this pull request Feb 27, 2023
Closed
@derrandz
Copy link
Contributor

Hi! Awesome changes! I think nodekit.IsSyncing should return !state Finished() instead.

@Bidon15 Bidon15 mentioned this pull request Feb 27, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 approved these changes

@sysrex sysrex Awaiting requested review from sysrex

@smuu smuu Awaiting requested review from smuu

Assignees

@Bidon15 Bidon15

Labels
test Request for creating a test-case testground related to testground
Projects
Celestia DevOps/Testing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bidon15 @derrandz @tty47