This repository has been archived by the owner on Dec 7, 2018. It is now read-only.
Refactor socket optimization by SocketMixin #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 12, 2013 16:54
…for SocketMixin )
|
|
||
| # Only Linux supports the mix of socket behaviors given in these optimizations. | ||
| # Beaware, certain optimizations may work individually off Linux; not together. | ||
| def optimize_socket socket |
There was a problem hiding this comment.
Celluloid's unspoken style guidelines follow "idiomatic Ruby" and require parens around parameters
|
Overall I'm not sure how this significantly improves Reel over what presently exists. These are the kind of optimizations that need to be justified by benchmarking. |
|
Closing in favor of #121 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After massive reworking of other areas, #114 was obsoleted.
This refits that code to the new reel/master and closes #114.
Noticed that after recent refactoring of how
Reel::Serveris instantiated,