Travis: Update Ruby versions in CI matrix #243

olleolleolle · 2017-05-17T07:02:47Z

This PR updates Ruby versions to latest releases in their series.

jruby-1.7.27
jruby-9.1.10.0
2.1.10
2.2.7
2.3.4
2.4.1 update! - added in this PR
wrap rake ci in bundle exec - update and then making it "the default Travis task" (removing its specific configuration from the Travis YAML config)
evict a Rake task file for rspec tests to the automatically available rakelib folder
Rid the Gemfile of some duplication, making it shorter and easier to follow

olleolleolle · 2017-05-17T07:02:55Z

Proposal: Perhaps we could let go of 2.1?

olleolleolle · 2017-05-17T14:19:53Z

The current JRuby 1.7 build failure is about http_form's missing required_ruby_version in its .gemspec which does not preclude 1.9 Rubies from automatically using it.

It'd be nice if that gem had such metadata in its .gemspec.

olleolleolle · 2017-05-17T14:25:41Z

JRuby 1.7 is EOL'd, would it be more beneficial in the long run to hop over to JRuby 9.1.9.0?

ixti · 2017-05-17T23:08:13Z

@olleolleolle I'm sorry about that. Will fix form_data asap

This commit contains no real changes except it reverts keyword args usage to use optional options hash instead for ruby < 2 compatibility. See: #16 celluloid/reel#243

This commit contains no real changes except it reverts keyword args usage to use optional options hash instead for ruby < 2 compatibility. Resoves #16 ------------------------------------------------------------------------ - #16 - celluloid/reel#243

ixti · 2017-05-18T17:13:29Z

@olleolleolle Can you please re-run tests. v1.0.3 of form data now fixed to play nice with jruby 1.7 and ruby 1.9+

olleolleolle · 2017-05-18T19:55:46Z

@ixti That fixed things here! Yes!

♥️ 💛 💚 💙 💜

olleolleolle · 2017-05-20T13:28:27Z

@digitalextremist Is there anything more you'd like from this PR? Or, any change you'd like to see done to it?

kenichi · 2017-06-08T05:41:29Z

.travis.yml

@@ -1,23 +1,19 @@
-script: rake ci
+script: bundle exec rake


i think this is default, we could remove script: ... altogether?

The default has more options. All of them good for us:

bundle install --jobs=3 --retry=3

https://docs.travis-ci.com/user/languages/ruby/#Travis-CI-uses-Bundler

I'll make this change!

kenichi · 2017-06-08T05:41:35Z

Gemfile

@@ -1,5 +1,8 @@
 source 'https://rubygems.org'

+ruby RUBY_VERSION
+
+gem 'bundler'


in the context of a gem intended to run on multiple ruby versions, does it make sense to specify in Gemfile? is bundler needed to be specified?

I can experiment with leaving it out - perhaps it is needed by the Rakefile, which gets read in our build.

Just so we talk about the same things, some basics: The Gemfile for a Rubygem is only a development and testing configuration tool. It won't affect users of the Rubygem.

The ruby RUBY_VERSION trick tells Bundler to "narrow your installation requirements to gems that support our current Ruby". Without this annotation, Bundler only has the version requirements like gem 'example', '~> 2.2', '>= 2.2.2' to narrow its gem version resolution with.

This allows a jruby-1.7.27 (Ruby 1.9) to navigate dependency chains which have Ruby 1.9/2.x differences (like json or mime-types libraries) in their "gem upgrade path", picking 1.9-compatible gems along the way.

Vacillating: Since a build takes a long time, I'd be happy to make the experimentation with dropping gem 'bundler' outside the context of this PR.

@kenichi Update: Have now tested without duplication of what was in the gemspec in the Gemfile, and it worked fine!

sorry @olleolleolle, GH hid these comments from me behind an "outdated diff", and I just thought to check. I do understand about the Gemfile vs. .gemspec for a gem. I'm reading & trying to learn more about this issue. I work on a project where this could be very helpful in our tests...

... but I'm really confused about this! https://gist.github.com/kenichi/bf9d83fc0a179850a45d2774281478ec

kenichi · 2017-06-08T05:43:10Z

.travis.yml

  - rvm: 2.1.8
-  - rvm: 2.3.0
+  - rvm: 2.3.4


should we add 2.4 as well?

I'm for such an addition, I'll add it!

kenichi · 2017-06-08T05:47:56Z

thank you - i think this is great as a specific PR, and i'm curious as to your thoughts about my other comments and what i've done to CI and deps in my own PR. i would be happy to revert/rebase from this!

.travis.yml
Gemfile
reel.gemspec

- spell out install in "gem install bundler" - include 2.4.1 in build

olleolleolle · 2017-06-08T13:24:55Z

@tarcieri I'm ready for code review on this one, now.

olleolleolle · 2017-06-08T15:15:27Z

@kenichi Oh, there we are, merged and good to go. Thank you for all of the input, it made this a lot better. Better is better!

kenichi · 2017-06-09T16:25:09Z

Gemfile

-gem 'celluloid'
-gem 'celluloid-io'
-gem 'http'
+ruby RUBY_VERSION


@olleolleolle @tarcieri sorry to harp on this, but this Gemfile directive is intended to specify a version of ruby the application requires. I don't think it's valid to use it here like this. thoughts?

I've been explicitly told by the Bundler developers to use ruby RUBY_VERSION to allow bundler to calculate variadic dependencies based on the current Ruby version, and that this behavior will become the default in future versions of Bundler.

found: rubygems/bundler#4651

ixti added a commit to httprb/form_data that referenced this pull request May 18, 2017

Prepare for v1.0.3 fix release

7dac300

This commit contains no real changes except it reverts keyword args usage to use optional options hash instead for ruby < 2 compatibility. See: #16 celluloid/reel#243

Travis: Update Ruby versions in CI matrix

cfd7ca8

olleolleolle force-pushed the patch-1 branch from 2c0d69e to cfd7ca8 Compare May 18, 2017 19:48

Travis: jruby-9.1.10.0

716b4aa

kenichi reviewed Jun 8, 2017

View reviewed changes

olleolleolle added 3 commits June 8, 2017 09:06

Travis: We can now use the default script step

bc1e962

- spell out install in "gem install bundler" - include 2.4.1 in build

Travis: include and update 2.1.8 to 2.1.10

d72ebc6

Gemfile: experiment away bundler gem

7670f92

tarcieri merged commit a180b37 into celluloid:master Jun 8, 2017

olleolleolle deleted the patch-1 branch June 8, 2017 15:13

kenichi reviewed Jun 9, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Travis: Update Ruby versions in CI matrix #243

Travis: Update Ruby versions in CI matrix #243

olleolleolle commented May 17, 2017 •

edited

Loading

olleolleolle commented May 17, 2017 •

edited

Loading

olleolleolle commented May 17, 2017 •

edited

Loading

olleolleolle commented May 17, 2017

ixti commented May 17, 2017

ixti commented May 18, 2017

olleolleolle commented May 18, 2017

olleolleolle commented May 20, 2017

kenichi Jun 8, 2017

olleolleolle Jun 8, 2017

kenichi Jun 8, 2017

olleolleolle Jun 8, 2017

olleolleolle Jun 8, 2017

olleolleolle Jun 8, 2017

kenichi Jun 9, 2017 •

edited

Loading

kenichi Jun 8, 2017

olleolleolle Jun 8, 2017

olleolleolle Jun 8, 2017

kenichi commented Jun 8, 2017

olleolleolle commented Jun 8, 2017

olleolleolle commented Jun 8, 2017

kenichi Jun 9, 2017

tarcieri Jun 9, 2017

kenichi Jun 9, 2017 •

edited

Loading

Travis: Update Ruby versions in CI matrix #243

Travis: Update Ruby versions in CI matrix #243

Conversation

olleolleolle commented May 17, 2017 • edited Loading

olleolleolle commented May 17, 2017 • edited Loading

olleolleolle commented May 17, 2017 • edited Loading

olleolleolle commented May 17, 2017

ixti commented May 17, 2017

ixti commented May 18, 2017

olleolleolle commented May 18, 2017

olleolleolle commented May 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenichi Jun 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenichi commented Jun 8, 2017

olleolleolle commented Jun 8, 2017

olleolleolle commented Jun 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenichi Jun 9, 2017 • edited Loading

Choose a reason for hiding this comment

olleolleolle commented May 17, 2017 •

edited

Loading

olleolleolle commented May 17, 2017 •

edited

Loading

olleolleolle commented May 17, 2017 •

edited

Loading

kenichi Jun 9, 2017 •

edited

Loading

kenichi Jun 9, 2017 •

edited

Loading