Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

'Stop' Reel gracefully. #44

Merged
merged 1 commit into from
Apr 16, 2013
Merged

'Stop' Reel gracefully. #44

merged 1 commit into from
Apr 16, 2013

Conversation

digitalextremist
Copy link
Member

Rack wants Reel to gracefully kill itself, but it had no hari-kari in its samurai style.
Paging Dr. Kevorkian, paging Dr. Kevorkian...

Rack wants Reel to gracefully kill itself, but it had no hari-kari in its samurai style.
tarcieri added a commit that referenced this pull request Apr 16, 2013
Paging Dr. Kevorkian, paging Dr. Kevorkian...
@tarcieri tarcieri merged commit 1eab8e3 into celluloid:master Apr 16, 2013
@tarcieri
Copy link
Member

Thanks!

@halorgium
Copy link
Contributor

@digitalextremist thanks for the PR. Could you name the issue something a bit nicer?
Jokes can be placed in the body and will be lovingly read!
Thanks.

@halorgium
Copy link
Contributor

This fixes #43.

@coveralls
Copy link

Coverage remained the same when pulling 0ae5bfc on digitalextremist:master into 3984f94 on celluloid:master.

View Details

@digitalextremist
Copy link
Member Author

Right on! Awesome! So glad to touch Reel, even if it's stopping it. Thank you both for being so present and involved in Celluloid and its relatives. This was my first serious pull request on github!

@tarcieri
Copy link
Member

Sweet ;)

@halorgium
Copy link
Contributor

Always good when someone else fixes bugs! Thanks!
Another random suggestion would be to use a different branch on your GitHub repo for doing your bugfixes. 👍

@digitalextremist
Copy link
Member Author

I will keep that in mind. I will maintain a bugfix branch and a features branch, since the main thing I am focused on right now is bringing in code reloading, sessions, multiroute support, and a way of being self-sufficient (i.e. MockRequest).

@coveralls
Copy link

Coverage remained the same when pulling 0ae5bfc on digitalextremist:master into 3984f94 on celluloid:master.

View Details

@halorgium
Copy link
Contributor

@digitalextremist branches are cheap, just make one for each change.

@digitalextremist
Copy link
Member Author

Copy that. My local development environment is a warzone right now, but I'll bring the features over one by one whenever I have something worth using.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants