-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages for credit/debit reverts #2271
Conversation
Coverage from tests in coverage: 51.3% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 43.3% of statements in consensus/istanbul/announce coverage: 55.9% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 66.3% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
3e875b1
to
063df84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this will make debugging much easier!
The revert messages now show up in the RPC responses. For most cases, this should provide enough debugging information without looking at the server logs.
063df84
to
fb7d647
Compare
Description
The revert messages now show up in the RPC responses (for calls). For most cases, this should provide enough debugging information without looking at the server logs.
Tested
Tested both cases manually by creating a fee currency that always fails in the respective method and sending a CIP-64 calls and txs via viem.
Backwards compatibility
Fully backwards compatible