Fee currency state transition test #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
force-pushed
the
palango/fee-currency-state-transition
branch
4 times, most recently
from
5c2c64a
to
9469fa9
Compare
palango
force-pushed
the
palango/fee-currency-state-transition-test
branch
from
d31cd0f
to
16fe6b3
Compare
palango
changed the base branch from
palango/fee-currency-state-transition
to
celo3
palango
commented
Nov 27, 2023
| @@ -641,7 +641,7 @@ func DeveloperGenesisBlock(gasLimit uint64, faucet common.Address) *Genesis { | |||
| } | |||
|
|
|||
| // Add state from celoGenesisAccounts | |||
| for addr, data := range celoGenesisAccounts() { | |||
| for addr, data := range celoGenesisAccounts(common.HexToAddress("0x2")) { | |||
There was a problem hiding this comment.
We could make this nicer with variadic args, but it felt like over-optimisation. Let me know if you disagree.
carterqw2
approved these changes
Nov 28, 2023
palango
force-pushed
the
palango/fee-currency-state-transition-test
branch
from
05653ac
to
2066e27
Compare
palango
force-pushed
the
palango/fee-currency-state-transition-test
branch
from
2066e27
to
38782aa
Compare
|
So the test actually found a bug: The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple fee currency transfer test.
The genesis initialisation of the
SortedOraclescontract is complicated, so instead I created a simpleMockSortedOraclecontract and use that instead. This is added to the optimism repo in celo-org/optimism#90.Resolves celo-org/optimism#86