Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging and Alfajores switch values #161

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Staging and Alfajores switch values #161

merged 9 commits into from
Nov 15, 2023

Conversation

alvarof2
Copy link
Member

@alvarof2 alvarof2 commented Nov 9, 2023

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

Documentation

The set of community facing docs that have been added/modified because of this change

Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: a52a7d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alvarof2
Copy link
Member Author

Set testQuotaBypassPercentage to 0. Pending for chart upgrade:

  • Remove testQuotaBypassPercentage value
  • Vars should follow the layout here

Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Left a few comments that might require updating the deployed combiner yaml, but otherwise 🚀

@alvarof2 alvarof2 merged commit 65a5fc0 into main Nov 15, 2023
8 checks passed
@alvarof2 alvarof2 deleted the switch-docs branch November 15, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants