Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add celo/utils test coverage #8

Merged
merged 2 commits into from Nov 3, 2023
Merged

test: add celo/utils test coverage #8

merged 2 commits into from Nov 3, 2023

Conversation

shazarre
Copy link

@shazarre shazarre commented Nov 3, 2023

This PR adds test coverage for src/chains/celo/utils.test.ts.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 58.26 KB (0%) 1.2 s (0%) 179 ms (-8.86% 🔽) 1.4 s
viem (cjs) 77.3 KB (0%) 1.6 s (0%) 332 ms (+49.42% 🔺) 1.9 s
viem (minimal surface - tree-shaking) 3.89 KB (0%) 78 ms (0%) 56 ms (-3.32% 🔽) 134 ms
viem/accounts 89.01 KB (0%) 1.8 s (0%) 117 ms (+2.38% 🔺) 1.9 s
viem/accounts (tree-shaking) 19.37 KB (0%) 388 ms (0%) 82 ms (+32.39% 🔺) 470 ms
viem/actions 43.33 KB (0%) 867 ms (0%) 1.4 s (+24.96% 🔺) 2.3 s
viem/actions (tree-shaking) 350 B (0%) 10 ms (0%) 38 ms (-26.92% 🔽) 48 ms
viem/chains 18.81 KB (0%) 377 ms (0%) 96 ms (-46.9% 🔽) 473 ms
viem/chains (tree-shaking) 470 B (0%) 10 ms (0%) 45 ms (+50.69% 🔺) 55 ms
viem/chains/utils 9.15 KB (0%) 183 ms (0%) 68 ms (-14.46% 🔽) 251 ms
viem/chains/utils (tree-shaking) 5.36 KB (0%) 108 ms (0%) 50 ms (+85.14% 🔺) 157 ms
viem/ens 43.33 KB (0%) 867 ms (0%) 1.4 s (+7.17% 🔺) 2.3 s
viem/ens (tree-shaking) 18.02 KB (0%) 361 ms (0%) 75 ms (-19.2% 🔽) 435 ms

@nicolasbrugneaux nicolasbrugneaux changed the title CELO utils test coverage test: add celo/utils test coverage Nov 3, 2023
@nicolasbrugneaux nicolasbrugneaux merged commit 2e949e3 into main Nov 3, 2023
14 of 22 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the shazarre/Celo_utils_test_coverage branch November 3, 2023 12:02
nicolasbrugneaux added a commit that referenced this pull request Nov 6, 2023
@nicolasbrugneaux @shazarre @jxom
fix: celo-specific transaction (CIP64) regressions (wevm#1434)
c0da695 
* Fix: cip64 regressions (#6)

* fix: refactor cip64 to be more robust

* fix: types

* fix: signTransaction tests

* refactor: PR feedback

* chore: add changeset

* test: add celo/utils test coverage (#8)

* CELO utils test coverage

* test: generate new address for each test

---------

Co-authored-by: Nicolas Brugneaux <nicolas.brugneaux@gmail.com>

* chore: update src/chains/celo/utils.ts

Co-authored-by: jxom  <jakemoxey@gmail.com>

* Update yellow-eggs-compare.md

---------

Co-authored-by: Leszek Stachowski <leszkostachowski@gmail.com>
Co-authored-by: jxom <jakemoxey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbrugneaux nicolasbrugneaux Awaiting requested review from nicolasbrugneaux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shazarre @nicolasbrugneaux