Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TA-2896: Send body as FormData on dataModel push #178

Merged
merged 2 commits into from
Mar 11, 2024
Merged

TA-2896: Send body as FormData on dataModel push #178

merged 2 commits into from
Mar 11, 2024

Conversation

LaberionAjvazi
Copy link
Contributor

Description

When switching to axios CtpDataModelManager.getBody method was not migrated, leading to invalid multipart request. This PR fixes the body format to send FormData.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@LaberionAjvazi LaberionAjvazi merged commit 5cb44be into master Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buqeta Buqeta Buqeta approved these changes

@ZgjimHaziri ZgjimHaziri ZgjimHaziri approved these changes

@jetakasabaqi jetakasabaqi jetakasabaqi approved these changes

@GencBlakqoriP9 GencBlakqoriP9 Awaiting requested review from GencBlakqoriP9 GencBlakqoriP9 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LaberionAjvazi @jetakasabaqi @ZgjimHaziri @Buqeta