fix: Environment checks in sanboxed environments #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliLay
changed the title
wmann-celonis
approved these changes
Aug 11, 2023
spirsch
approved these changes
Aug 14, 2023
Co-authored-by: Simon Pirsch <95348275+spirsch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue that has been there for quite a while now: previously, we would not check if a compiler exists in a sandboxed environment (and e.g. also, if it supports the selected target), leading to weird errors. This made especially setting up cross-compiling harder.
I refactored this now, so that we always know in which context (= shell environment) we are in, by introducing an abstract
ShellEnvironmentclass. Inheriting classes must implementtransform_command, which transforms a command so that it is executed inside a sandbox. When executing a command, we must now always pass the context in which we are in and in which the command should be executed.This makes the code cleaner, and allows us to check all environment related things also in the sandbox.