Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Typescript #1

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Migrate to Typescript #1

merged 4 commits into from
Mar 7, 2022

Conversation

celsofabri
Copy link
Owner

Description

Migrate all files to TypeScript

@celsofabri celsofabri added the enhancement New feature or request label Mar 7, 2022
@celsofabri celsofabri requested a review from jlozovei March 7, 2022 18:51
@celsofabri celsofabri self-assigned this Mar 7, 2022
Copy link
Collaborator

@jlozovei jlozovei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the moon and back 🚀

@@ -8,7 +8,7 @@
"build": "react-scripts build",
"test": "react-scripts test",
"test:lint": "yarn eslint . --ignore-path .gitignore --ext .js",
"format": "prettier \"src/**/*.{js,jsx,json,css}\" --write",
"format": "prettier \"src/**/*.{js,jsx,ts,tsx,scss,sass,css,json}\" --write",
"predeploy": "yarn build",
"deploy": "gh-pages -d build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend you to use GitHub Actions to deploy instead of using this package.

Check out: https://github.com/marketplace/actions/deploy-to-github-pages 🚀

Copy link
Owner Author

@celsofabri celsofabri Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change after this to Github Actions. Thanks ❤️

@celsofabri celsofabri merged commit 7889b8f into master Mar 7, 2022
@celsofabri celsofabri deleted the feat/migrate-to-typescript branch March 7, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants