Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow multiple versions of one application #215

Merged
merged 9 commits into from
Jul 19, 2024
Merged

feat: allow multiple versions of one application #215

merged 9 commits into from
Jul 19, 2024

Conversation

RDWimmers
Copy link
Member

@RDWimmers RDWimmers commented Jul 18, 2024 •
edited
Loading

V1.0.0

@RDWimmers RDWimmers added documentation Improvements or additions to documentation enhancement New feature or request python Pull requests that update Python code labels Jul 18, 2024
@RDWimmers RDWimmers requested a review from tversteeg July 18, 2024 15:32
@RDWimmers RDWimmers self-assigned this Jul 18, 2024
@coveralls
Copy link

coveralls commented Jul 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10007163770

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.0%) to 86.667%
Files with Coverage Reduction New Missed Lines %
client/utils.py 3 81.25%
client/main.py 16 83.0%
Totals Coverage Status
Change from base Build 9658921634: 1.0%
Covered Lines: 130
Relevant Lines: 150
💛 - Coveralls

PabloVasconez
PabloVasconez reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@PabloVasconez PabloVasconez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good. Nice feature! There are some minor comments mainly documentation (most of them added as suggestions), but also a bit of code missing regarding TypeError or ValueError(s).

src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
src/nuclei/client/main.py Outdated Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
@RDWimmers RDWimmers merged commit df8ee66 into main Jul 19, 2024
17 checks passed
@RDWimmers RDWimmers deleted the feat-allow-multiple-versions-of-one-app branch July 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tversteeg tversteeg tversteeg left review comments

@PabloVasconez PabloVasconez PabloVasconez left review comments

Assignees

@RDWimmers RDWimmers

Labels
documentation Improvements or additions to documentation enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RDWimmers @coveralls @tversteeg @PabloVasconez