Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cpt-class validation #385

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Remove cpt-class validation #385

merged 2 commits into from
Sep 23, 2024

Conversation

tlukkezen
Copy link
Collaborator

closes #384

@tlukkezen tlukkezen linked an issue Sep 20, 2024 that may be closed by this pull request
Remove validation on cpt quality class #384
Closed
@tlukkezen tlukkezen self-assigned this Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10990389878

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.7%) to 88.605%
Files with Coverage Reduction New Missed Lines %
cpt.py 6 92.59%
gef/utils.py 8 89.36%
broxml/resolvers.py 9 79.83%
Totals Coverage Status
Change from base Build 10661960988: 0.7%
Covered Lines: 972
Relevant Lines: 1097
💛 - Coveralls

tversteeg
tversteeg approved these changes Sep 23, 2024
View reviewed changes
src/pygef/cpt.py Outdated Show resolved Hide resolved
@tlukkezen tlukkezen force-pushed the 384-remove-validation-on-cpt-quality-class branch from 39c40ca to 7cde942 Compare September 23, 2024 08:05
@tlukkezen tlukkezen force-pushed the 384-remove-validation-on-cpt-quality-class branch from 7cde942 to 9127fe9 Compare September 23, 2024 08:21
@tlukkezen tlukkezen merged commit 308b0c9 into master Sep 23, 2024
14 checks passed
@tlukkezen tlukkezen deleted the 384-remove-validation-on-cpt-quality-class branch September 23, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tversteeg tversteeg tversteeg approved these changes

@RDWimmers RDWimmers Awaiting requested review from RDWimmers

Assignees

@tlukkezen tlukkezen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove validation on cpt quality class
3 participants
@tlukkezen @coveralls @tversteeg