Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows default to non-portable + Reworked MLC handling and related UI #1252

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

Exzap
Copy link
Member

@Exzap Exzap commented Jul 7, 2024

The Windows version of Cemu is currently the only version that is portable by default. While personally I am a fan of applications that are portable, this has been a constant troubleshooting burden with users losing their files due to deleting the Cemu directory or moving stuff around. It's especially bad with the mlc01 location which isn't really an intuitive concept and is easily "misplaced".

Since directory and MLC handling are intertwined with the UI I ended up overhauling parts of that as well. In summary the changes are:

  • The Windows version is now non-portable by default (files stored to %appdata%/Roaming/Cemu). Similar to Linux/MacOS portable mode is still supported by creating a directory portable next to the executable. If settings.xml is detected in the same directory as Cemu.exe, it will operate in the previous portable mode to avoid breaking existing installations
  • UI is no longer encouraging the user to set a custom MLC, but the option is still there
  • Getting Started dialog and General Settings UI have been reworked to align with these changes
  • Some more UI tweaks here and there. Added extra description texts and message boxes to clarify things

I would appreciate if people could test this build and let me know if there are any issues with their existing installs regardless of what OS is being used

@Exzap
Copy link
Member Author

Exzap commented Jul 7, 2024

Some screenshots of UI.
Getting Started before:
image
After:
image

General Settings before:
image
After:
image

@Fs00
Copy link
Contributor

Fs00 commented Jul 7, 2024

When I first tried portable mode, I encountered a bug that caused UI translations not to be loaded because Cemu was looking for the resources folder inside the portable folder, instead of near the executable. I can't tell by looking at the code if that's fixed now, but it's worth checking before merging.

Also, IMO it would be nice to make portable mode more discoverable. A way to do that could be to have a message along the lines of "Cemu will save your data to [path]. If you wish to have them stored close to Cemu executable, create a folder named 'portable' in that location" in place of "Cemu is running in portable mode" when no portable folder is found.

@Exzap
Copy link
Member Author

Exzap commented Jul 7, 2024

resources lookup is still broken under some conditions, thanks for letting me know. I'll look into fixing it before merging

src/gui/CemuApp.cpp Outdated Show resolved Hide resolved
@Exzap Exzap merged commit 64232ff into cemu-project:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants