Remove context deadline checking in backOffContext #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
backOffContext
checks the context's deadline and marks it as cancelled even when that deadline is not reached yet. This leads to confusion on theRetryNotifyWithTimer
caller's side, because there are no clear indications whether the execution was stopped due to the context reaching its deadline (context.DeadlineExceeded
is not returned) or some other error. Even checking whether the context is cancelled after the retry func returns, does not work because the context itself might not have been cancelled (onlybackOffContext
marked it internally as being so):