Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of pkg_resources optional #45

Closed
wants to merge 1 commit into from
Closed

Conversation

frol
Copy link
Contributor

@frol frol commented Oct 21, 2016

pkg_resources is a part of setuptools package, which is neither available nor used in Anaconda Python for entrypoints.

When setuptools is not installed, Kuyruk fails with the following traceback:

import: 'kuyruk'
Traceback (most recent call last):
  File "/staged-recipes/build_artefacts/test-tmp_dir/run_test.py", line 26, in <module>
    import kuyruk
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/kuyruk/__init__.py", line 9, in <module>
    from kuyruk.config import Config
  File "/opt/conda/envs/_test/lib/python2.7/site-packages/kuyruk/config.py", line 6, in <module>
    import pkg_resources
ImportError: No module named pkg_resources

So, you cannot even import kuyruk.

@frol
Copy link
Contributor Author

frol commented Oct 21, 2016

Oh, wait, it is not all.

@cenkalti
Copy link
Owner

Hello @frol.

I don't have enough information on this subject. And I couldn't find it after searching. Can you tell me why setuptools is not available on Anaconda?

`pkg_resources` is a part of `setuptools` package, which is neither available nor used in Anaconda Python for entrypoints.
@frol
Copy link
Contributor Author

frol commented Oct 21, 2016

Anaconda has its own package manager (conda), and also its own reimplementation of entry-points, so even if we require setuptools as a "run" dependency, it won't have much use, though it won't fail, so it is also a way to go instead of this patching.

@coveralls
Copy link

coveralls commented Oct 21, 2016

Coverage Status

Coverage decreased (-0.5%) to 82.765% when pulling 6614f70 on frol:patch-2 into 6971f4b on cenkalti:master.

@cenkalti
Copy link
Owner

setuptools is pretty standard these days and I don't want to put conda specific logic into the code. So if there is another way without merging this PR I will be more happy.

@coveralls
Copy link

coveralls commented Oct 21, 2016

Coverage Status

Coverage decreased (-0.5%) to 82.765% when pulling 6614f70 on frol:patch-2 into 6971f4b on cenkalti:master.

@frol
Copy link
Contributor Author

frol commented Oct 21, 2016

OK, let's drop this.

@frol frol closed this Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants