Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch issue #37 #40

Closed
wants to merge 5 commits into from
Closed

Patch issue #37 #40

wants to merge 5 commits into from

Conversation

bsergean
Copy link
Contributor

@bsergean bsergean commented Oct 19, 2021

Should fix #37

@coveralls
Copy link

coveralls commented Oct 19, 2021

Pull Request Test Coverage Report for Build 1360447797

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 45.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
torrent/torrent_write.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
torrent/torrent_write.go 1 56.06%
torrent/torrent_messagehandler.go 4 43.89%
Totals Coverage Status
Change from base Build 1344396027: -0.07%
Covered Lines: 3301
Relevant Lines: 7291

💛 - Coveralls

@cenkalti
Copy link
Owner

@bsergean Thanks for you patches. I am busy currently but I'll try to review them on next weekend. Sorry for the delay.

@bsergean
Copy link
Contributor Author

bsergean commented Oct 26, 2021 via email

@cenkalti
Copy link
Owner

Committed an alternative fix in 3b0d35e

@cenkalti cenkalti closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: already have the piece #987
3 participants