-
Notifications
You must be signed in to change notification settings - Fork 76
Add gtest_force_shared_crt for MSVC #284
Add gtest_force_shared_crt for MSVC #284
Conversation
Please describe why this is being done. |
This is being done simply because the build (or, to be more specifik, the linking) on MSVC fails when abseil and opencensus-cpp compile with /MD, and googletest compiles with /MT.
|
Makes sense. Thanks a lot for the followup. Please run |
I'm on Windows, so I can not run tools/format.sh directly, but by reading the script I think only the following applies to my changes (I'm not familiar with the
If this is correct I'll fix that. Please confirm that my understanding is correct... :) |
Those definitely apply, but cmake-format might be in play for this PR as well. |
It's not just whitespace. I did the format on my end but I don't think I can push it to this PR:
Please apply this commit to the PR: g-easy@17cc862 |
If you prefer, I can try to do it in the online editor. :) |
Thanks, I managed to merge your commit online by creating a pull request with |
No description provided.