Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

trace/config_test fails if ran out of order. #1193

Closed
rghetia opened this issue Feb 1, 2020 · 0 comments · Fixed by #1194
Closed

trace/config_test fails if ran out of order. #1193

rghetia opened this issue Feb 1, 2020 · 0 comments · Fixed by #1194
Assignees
@rghetia
Labels
bug

Comments

@rghetia
Copy link
Contributor

rghetia commented Feb 1, 2020

The first case in the TestApplyConfig expects that it is the first test that runs in the package. Applying empty Config (Config{}) doesn't mean change it to default but rather keep the previous configuration as is. So, if another test ran before this test AND change the config then this test would fail.

This was detect in random test.
@rghetia rghetia added the bug label Feb 1, 2020
@rghetia rghetia self-assigned this Feb 1, 2020
rghetia added a commit to rghetia/opencensus-go that referenced this issue Feb 1, 2020
@rghetia
fix config_test to run in any order.
a7360a6 
- fixes census-instrumentation#1193
@rghetia rghetia mentioned this issue Feb 1, 2020
Merged
rghetia added a commit that referenced this issue Feb 2, 2020
@rghetia
fix config_test to run in any order. (#1194)
d835ff8 
- fixes #1193
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rghetia rghetia

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix config_test to run in any order. rghetia/opencensus-go
1 participant
@rghetia