Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Change the licence to OpenCensus authors. #539

Merged

Conversation

bogdandrutu
Copy link
Contributor

No description provided.

Copy link
Contributor

@sebright sebright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let @tags07 approve it.

^ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.$
^ \* See the License for the specific language governing permissions and$
^ \* limitations under the License\.$
^ \*/$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@tags07 tags07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments:

  1. Add a line between the copyright statement and License text.
  2. Update copyright years to include all date ranges esp. for the ones that was updated in 2017 but created or pre-existed in 2016 or before.

Its not a blocker.. something to fix in a future release.

@codecov-io
Copy link

codecov-io commented Aug 22, 2017

Codecov Report

Merging #539 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #539   +/-   ##
=========================================
  Coverage     90.02%   90.02%           
  Complexity      565      565           
=========================================
  Files           110      110           
  Lines          2355     2355           
  Branches        208      208           
=========================================
  Hits           2120     2120           
  Misses          180      180           
  Partials         55       55
Impacted Files Coverage Δ Complexity Δ
...us/implcore/trace/export/SampledSpanStoreImpl.java 92.64% <ø> (ø) 15 <0> (ø) ⬇️
...n/java/io/opencensus/tags/unsafe/ContextUtils.java 83.33% <ø> (ø) 1 <0> (ø) ⬇️
...s/implcore/trace/propagation/BinaryFormatImpl.java 89.65% <ø> (ø) 8 <0> (ø) ⬇️
.../opencensus/impl/internal/DisruptorEventQueue.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...ncensus/implcore/trace/TraceComponentImplBase.java 94.44% <ø> (ø) 6 <0> (ø) ⬇️
...src/main/java/io/opencensus/stats/ViewManager.java 100% <ø> (ø) 1 <0> (ø) ⬇️
api/src/main/java/io/opencensus/trace/Span.java 100% <ø> (ø) 9 <0> (ø) ⬇️
.../main/java/io/opencensus/trace/EndSpanOptions.java 100% <ø> (ø) 3 <0> (ø) ⬇️
.../main/java/io/opencensus/trace/TraceComponent.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...opencensus/trace/samplers/AlwaysSampleSampler.java 100% <ø> (ø) 3 <0> (ø) ⬇️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8f6e4...0008ebf. Read the comment docs.

@bogdandrutu
Copy link
Contributor Author

@tags07 Done.

@bogdandrutu bogdandrutu merged commit b2f48c5 into census-instrumentation:master Aug 23, 2017
@bogdandrutu bogdandrutu deleted the changelicence branch August 30, 2017 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants