-
Notifications
You must be signed in to change notification settings - Fork 96
Update dependency google-auth-library to v2 - autoclosed #243
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
8d7e3c7
to
dde42af
Compare
43c4c4c
to
5c8398c
Compare
228b3f8
to
5f9659e
Compare
a65ca39
to
99ff32f
Compare
This build failure is related to googleapis/google-auth-library-nodejs#520, looks like we need to first update TypeScript -> 3.1.x. |
268c01a
to
d2eef64
Compare
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
d2eef64
to
d43dd48
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 110 110
Lines 7771 7771
Branches 714 714
=======================================
Hits 7368 7368
Misses 403 403 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 110 110
Lines 7771 7771
Branches 714 714
=======================================
Hits 7368 7368
Misses 403 403 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 110 110
Lines 7421 7421
Branches 680 680
=======================================
Hits 7019 7019
Misses 402 402 Continue to review full report at Codecov.
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
d43dd48
to
bce5720
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
bce5720
to
2268615
Compare
This PR contains the following updates:
^1.5.0
->^2.0.0
Release Notes
google/google-auth-library-nodejs
v2.0.2
Compare Source
12-16-2018 10:48 PST
Fixes
Dependencies
Documentation
Internal / Testing Changes
v2.0.1
Compare Source
Implementation Changes
Dependencies
Documentation
Internal / Testing Changes
v2.0.0
Compare Source
Well hello 2.0 🎉 This release has multiple breaking changes. It also has a lot of bug fixes.
Breaking Changes
Support for node.js 4.x and 9.x has been dropped
These versions of node.js are no longer supported.
The
getRequestMetadata
method has been deprecatedThe
getRequestMetadata
method has been deprecated on theIAM
,OAuth2
,JWT
, andJWTAccess
classes. ThegetRequestHeaders
method should be used instead. The methods have a subtle difference: thegetRequestMetadata
method returns an object with a headers property, which contains the authorization header. ThegetRequestHeaders
method simply returns the headers.Old code
New code
The
createScopedRequired
method has been deprecatedThe
createScopedRequired
method has been deprecated on multiple classes. ThecreateScopedRequired
andcreateScoped
methods on theJWT
class were largely in place to help inform clients when scopes were required in an application default credential scenario. Instead of checking if scopes are required after creating the client, instead scopes should just be passed either into theGoogleAuth.getClient
method, or directly into theJWT
constructor.Old code
New code
The
refreshAccessToken
method has been deprecatedThe
OAuth2.refreshAccessToken
method has been deprecated. ThegetAccessToken
,getRequestMetadata
, andrequest
methods will all refresh the token if needed automatically. There is no need to ever manually refresh the token.As always, if you run into any problems... please let us know!
Features
Bug Fixes
Buffer.from
instead ofnew Buffer
(#400)Breaking changes
createScopedRequired
methods (#410)refreshAccessToken
methods (#411)getDefaultProjectId
method (#402)Build / Test changes
Renovate configuration
📅 Schedule: "after 9am and before 3pm" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.