-
Notifications
You must be signed in to change notification settings - Fork 96
Jaeger exporter: remove require wrapper and make requires direct #302
Jaeger exporter: remove require wrapper and make requires direct #302
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it!
…On Mon, Jan 21, 2019 at 1:34 PM googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google.com/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#302 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACdjry-CWQn_xk70kTZlHbtKsgNhOpJpks5vFiRxgaJpZM4aLfYc>
.
|
CLAs look good, thanks! |
Please rebase and fix the build |
09ee1d9
to
875b911
Compare
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 94.77% 94.77% -0.01%
==========================================
Files 136 136
Lines 8942 8938 -4
Branches 650 650
==========================================
- Hits 8475 8471 -4
Misses 467 467
Continue to review full report at Codecov.
|
@mayurkale22 ready for rereview. |
Motivation
See #301.
It seems like this was done for developer convenience, and this function is only used in this file. While I don't have a problem with that in principle, it breaks things for Webpack.
Changes
Remove the require wrapper and make the requires direct
Testing
See that the build still builds correctly.