Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Jaeger exporter: remove require wrapper and make requires direct #302

Merged

Conversation

tstirrat15
Copy link
Contributor

Motivation

See #301.

It seems like this was done for developer convenience, and this function is only used in this file. While I don't have a problem with that in principle, it breaks things for Webpack.

Changes

Remove the require wrapper and make the requires direct

Testing

See that the build still builds correctly.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tstirrat15
Copy link
Contributor Author

tstirrat15 commented Jan 21, 2019 via email

@googlebot
Copy link

CLAs look good, thanks!

@mayurkale22
Copy link
Member

Please rebase and fix the build

@codecov-io
Copy link

Codecov Report

Merging #302 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   94.77%   94.77%   -0.01%     
==========================================
  Files         136      136              
  Lines        8942     8938       -4     
  Branches      650      650              
==========================================
- Hits         8475     8471       -4     
  Misses        467      467
Impacted Files Coverage Δ
src/jaeger-driver/index.ts 96.87% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f83a1...fabbb18. Read the comment docs.

@tstirrat15
Copy link
Contributor Author

@mayurkale22 ready for rereview.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants