This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Update examples to work with global stats instance #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@DazWilkin for review. |
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 120 120
Lines 8332 8332
Branches 741 741
=======================================
Hits 7914 7914
Misses 418 418Continue to review full report at Codecov.
|
draffensperger
approved these changes
Feb 12, 2019
| export GOOGLE_APPLICATION_CREDENTIALS=path/to/your/credential.json | ||
| ``` | ||
|
|
||
| Instance the exporter on your application. |
There was a problem hiding this comment.
Nit: did you mean "Install the exporter ..."?
There was a problem hiding this comment.
Copied from top example (Trace Exporter), amended both the sentence.
|
+@alexamies for review (especially |
mayurkale22
force-pushed
the
update_example
branch
2 times, most recently
from
5867924
to
371169a
Compare
mayurkale22
force-pushed
the
update_example
branch
from
371169a
to
23036b4
Compare
Looks good. Thanks for making the changes in the web_client_monitoring example. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains updated examples based on CHAGELOG -> https://github.com/census-instrumentation/opencensus-node/blob/master/CHANGELOG.md#new-code
Also, added ReadMe for the Stackdriver Stats(Metrics) exporter.