-
Notifications
You must be signed in to change notification settings - Fork 96
implement redis instrumentation plugin #359
implement redis instrumentation plugin #359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 95.23% 95.22% -0.02%
==========================================
Files 129 131 +2
Lines 8592 8758 +166
Branches 634 638 +4
==========================================
+ Hits 8183 8340 +157
- Misses 409 418 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for taking the initiative on this!
I have a bunch of nit-picky comments, but overall this is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, I have added a few comments.
I believe i addressed every comment, note that the test failures are related to Stackdriver and not the PR itself |
Please rebase the PR, this should fix build issue. |
This is good to go, please rebase once. |
@mayurkale22 Done |
Thanks for the contribution again! If possible, please include redis instrumentation example in examples package. |
Yes, no problem. I will try to make another PR with the support for |
Not sure if everything is okay it terms of setup since i don't use lerna a lot, same with circleCI.
I've set the version to 0.0.1 but i believe you guys have all the packages at the same version for now, feel free to do it as you want.
I also choose not to add it into the
instrumentation-all
packages directly too, but i could do another PR if the plugin in itself is good.cc @draffensperger @mayurkale22