Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

gRPC plugin : Rename metrics to stats #374

Merged

Conversation

mayurkale22
Copy link
Member

At the high level, metrics are used for already aggregated data like Gauge/Counter whereas Stats are for non-aggreagated data (View + Measure + Tags). I think it makes sense to rename metrics to stats for gRPC data recording.
Shortly, we planned to publish specs to explain the diff between these two and when to use Stats/Metrics.

@codecov-io
Copy link

Codecov Report

Merging #374 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   95.23%   95.21%   -0.02%     
==========================================
  Files         128      128              
  Lines        8492     8492              
  Branches      628      628              
==========================================
- Hits         8087     8086       -1     
- Misses        405      406       +1
Impacted Files Coverage Δ
src/stackdriver-monitoring.ts 83.15% <0%> (-1.06%) ⬇️
test/test-grpc.ts 99.68% <0%> (ø) ⬆️
src/grpc.ts 93.69% <0%> (ø) ⬆️
src/grpc-stats/server-metrics.ts
src/grpc-stats/client-metrics.ts
src/grpc-stats/server-stats.ts 100% <0%> (ø)
src/grpc-stats/client-stats.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7606e...13a3ba2. Read the comment docs.

@mayurkale22 mayurkale22 merged commit bc0de66 into census-instrumentation:master Feb 28, 2019
@mayurkale22 mayurkale22 deleted the grpc_metrics_to_stats branch February 28, 2019 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants