This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Exporter/Stackdriver: Enforce strictNullChecks and noUnusedLocals #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
force-pushed
the
enforce_strictNullcheck_stackdriver
branch
from
370d5f5
to
913c1ec
Compare
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
draffensperger
approved these changes
Mar 11, 2019
| @@ -39,8 +39,8 @@ export class StackdriverStatsExporter implements StatsEventListener { | |||
| private projectId: string; | |||
| private metricPrefix: string; | |||
| private displayNamePrefix: string; | |||
| private onMetricUploadError: (err: Error) => void; | |||
| private timer: NodeJS.Timer; | |||
| private onMetricUploadError!: (err: Error) => void; | |||
There was a problem hiding this comment.
Why is the ! needed here, could this be ? instead and then just handle the cases where it's missing?
mayurkale22
force-pushed
the
enforce_strictNullcheck_stackdriver
branch
from
913c1ec
to
7d2ec3e
Compare
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 94.8% 95.36% +0.55%
==========================================
Files 136 89 -47
Lines 8997 5393 -3604
Branches 663 313 -350
==========================================
- Hits 8530 5143 -3387
+ Misses 467 250 -217
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #348