Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix missing gitter links #519

Merged

Conversation

mayurkale22
Copy link
Member

No description provided.

@mayurkale22
Copy link
Member Author

@hekike please review. Looks like Gitter chat link is broken in npm: https://www.npmjs.com/package/@opencensus/nodejs-base

@codecov-io
Copy link

Codecov Report

Merging #519 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   95.19%   94.93%   -0.27%     
==========================================
  Files         147      147              
  Lines       10562    10781     +219     
  Branches      919      912       -7     
==========================================
+ Hits        10055    10235     +180     
- Misses        507      546      +39
Impacted Files Coverage Δ
test/test-http2.ts 77.83% <0%> (-18.99%) ⬇️
src/trace/propagation/noop-propagation.ts 40% <0%> (-10%) ⬇️
src/common/noop-logger.ts 11.11% <0%> (-5.56%) ⬇️
src/stackdriver-monitoring.ts 78.65% <0%> (-3.38%) ⬇️
test/test-ioredis.ts 97.16% <0%> (-0.55%) ⬇️
src/tracecontext-format.ts 96.42% <0%> (-0.19%) ⬇️
test/test-tracecontext-format.ts 99.06% <0%> (-0.04%) ⬇️
src/internal/string-utils.ts 100% <0%> (ø) ⬆️
test/test-tag-map.ts 100% <0%> (ø) ⬆️
test/test-metric-producer-manager.ts 100% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ef1a0...cf708e1. Read the comment docs.

@hekike
Copy link
Contributor

hekike commented May 13, 2019

lgtm, I've no review perm btw.

@mayurkale22 mayurkale22 merged commit 1a77de1 into census-instrumentation:master May 13, 2019
@mayurkale22 mayurkale22 deleted the nodejs-base-readme branch May 13, 2019 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants