Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix jaeger config syntax #522

Merged
merged 1 commit into from
May 16, 2019
Merged

Conversation

drubin
Copy link
Contributor

@drubin drubin commented May 14, 2019

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drubin
Copy link
Contributor Author

drubin commented May 14, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #522 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   95.15%   95.17%   +0.01%     
==========================================
  Files         147      147              
  Lines        9762    10564     +802     
  Branches      535      919     +384     
==========================================
+ Hits         9289    10054     +765     
- Misses        473      510      +37
Impacted Files Coverage Δ
src/detect-resource.ts 90.9% <0%> (-9.1%) ⬇️
src/http2.ts 80.64% <0%> (-8.65%) ⬇️
src/trace/model/tracer.ts 66.66% <0%> (-3.11%) ⬇️
src/trace/instrumentation/base-plugin.ts 9.52% <0%> (-1.59%) ⬇️
test/test-http2.ts 96.81% <0%> (-1.22%) ⬇️
test/test-detect-resource.ts 99.13% <0%> (-0.87%) ⬇️
test/test-zpages.ts 99.27% <0%> (-0.36%) ⬇️
src/internal/string-utils.ts 100% <0%> (ø) ⬆️
src/http-stats.ts 100% <0%> (ø) ⬆️
src/tags/tag-map.ts 100% <0%> (ø) ⬆️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940ef79...73e8705. Read the comment docs.

maxPacketSize: 65000; // optional
serviceName: 'my-service',
tags: [], // optional
host: localhost, // optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Please include a single quote around localhost.

@mayurkale22
Copy link
Member

@drubin Thanks for the PR. LGTM.

@mayurkale22 mayurkale22 merged commit 056fee7 into census-instrumentation:master May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants