-
Notifications
You must be signed in to change notification settings - Fork 97
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 95.15% 95.17% +0.01%
==========================================
Files 147 147
Lines 9762 10564 +802
Branches 535 919 +384
==========================================
+ Hits 9289 10054 +765
- Misses 473 510 +37
Continue to review full report at Codecov.
|
maxPacketSize: 65000; // optional | ||
serviceName: 'my-service', | ||
tags: [], // optional | ||
host: localhost, // optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Please include a single quote around localhost.
@drubin Thanks for the PR. LGTM. |
No description provided.