Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Change CLS import to make stats types more general. (Fix #527) #528

Merged

Conversation

crdgonzalezca
Copy link
Contributor

This PR fixes Issue #527.

  • Adds a Default function declaration in @opencensus/core stats/types.ts to avoid import of internal functionality.
  • As small change, adds missing semicolon.

@codecov-io
Copy link

Codecov Report

Merging #528 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   94.89%   95.15%   +0.26%     
==========================================
  Files         146      147       +1     
  Lines        9379    10547    +1168     
  Branches      537      912     +375     
==========================================
+ Hits         8900    10036    +1136     
- Misses        479      511      +32
Impacted Files Coverage Δ
src/http2.ts 80.64% <0%> (-8.65%) ⬇️
test/test-instana.ts 85.18% <0%> (-3.28%) ⬇️
src/trace/model/tracer.ts 66.66% <0%> (-3.11%) ⬇️
src/trace/instrumentation/base-plugin.ts 9.52% <0%> (-1.59%) ⬇️
test/test-http2.ts 96.81% <0%> (-1.22%) ⬇️
test/test-zpages.ts 99.27% <0%> (-0.36%) ⬇️
src/internal/string-utils.ts 100% <0%> (ø) ⬆️
src/http-stats.ts 100% <0%> (ø) ⬆️
src/tags/tag-map.ts 100% <0%> (ø) ⬆️
test/test-tag-map.ts 100% <0%> (ø) ⬆️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800520f...9eee46b. Read the comment docs.

@mayurkale22
Copy link
Member

@crdgonzalezca Thanks for the issue and PR.

@mayurkale22 mayurkale22 merged commit 26c232c into census-instrumentation:master May 15, 2019
@crdgonzalezca crdgonzalezca deleted the refactoring branch May 15, 2019 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants