Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

doc: add some use info to CONTRIBUTING.md #531

Merged

Conversation

mhdawson
Copy link
Contributor

Adding some information that would have been useful
to me when I was working on my first commit.

Adding some information that would have been useful
to me when I was working on my first commit.
@mhdawson
Copy link
Contributor Author

Note that I suggested npm run check as opposed to npm run test at the top level since the tests don't seem to all pass.

@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #531 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   95.15%   95.01%   -0.14%     
==========================================
  Files         147      147              
  Lines        9861     9505     -356     
  Branches      541      532       -9     
==========================================
- Hits         9383     9031     -352     
+ Misses        478      474       -4
Impacted Files Coverage Δ
src/common-utils.ts 75% <0%> (-20.24%) ⬇️
test/test-stackdriver-cloudtrace.ts 92% <0%> (-6.96%) ⬇️
test/test-stackdriver-monitoring-utils.ts 93.33% <0%> (-6.67%) ⬇️
test/test-zipkin.ts 91.66% <0%> (-6.07%) ⬇️
test/test-tracecontext-format.ts 98.76% <0%> (-0.15%) ⬇️
...c/zpages-frontend/controllers/tracez.controller.ts 100% <0%> (ø) ⬆️
...es-frontend/controllers/traceconfigz.controller.ts 100% <0%> (ø) ⬆️
src/zpages-frontend/controllers/rpcz.controller.ts 100% <0%> (ø) ⬆️
src/zpages-frontend/routes.ts 100% <0%> (ø) ⬆️
src/validators.ts 100% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c232c...01c7e87. Read the comment docs.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM!

@mayurkale22 mayurkale22 merged commit afc3268 into census-instrumentation:master May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants