Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sqlalchemy upper limit version #1142

Merged
merged 1 commit into from
Nov 17, 2022
Merged

remove sqlalchemy upper limit version #1142

merged 1 commit into from
Nov 17, 2022

Conversation

lwatskot
Copy link
Contributor

@lwatskot
Copy link
Contributor Author

@lzchen can you please take a look at this?

@javier-martinez-codurance
Copy link

@hectorhdzg Hi, brief question do you know if the upper limit was there for a reason? I would like to add the extension but due to this constraint I can not do it properly. Thanks in advance!

@martin-greentrax martin-greentrax mentioned this pull request Aug 9, 2022
Closed
8 tasks
@lwatskot
Copy link
Contributor Author

@hectorhdzg @lzchen can you please take a look at this?

@aberres
Copy link
Contributor

aberres commented Aug 11, 2022

Getting this merged would be great!

@panteamihai
Copy link

@hectorhdzg @lzchen @aabmass could you guys please take a look at this?

aabmass
aabmass approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and apologies for the slow response.

It looks like SQLAlchemy doesn't support python 3.4 anymore at all. https://github.com/sqlalchemy/sqlalchemy/blob/main/setup.cfg#L34. I think this change is fine as it is the user's responsiblity to pin the correct version of SQLAlchemy for their python interpreter version.

@lzchen lzchen merged commit e4d0804 into census-instrumentation:master Nov 17, 2022
@iensu iensu mentioned this pull request Dec 16, 2022
Open
inirudebwoy pushed a commit to inirudebwoy/opencensus-python that referenced this pull request Jan 11, 2023
@lwatskot @inirudebwoy
remove sqlalchemy upper limit version (census-instrumentation#1142)
0a28f71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@lzchen lzchen lzchen approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lwatskot @javier-martinez-codurance @aberres @panteamihai @aabmass @lzchen