Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SD exporter to 0.7.1 for release #749

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

c24t
Copy link
Member

@c24t c24t commented Aug 5, 2019

#747 bumped opencensus-ext-exporter to 0.5.0, but to be consistent with the core library releases this should be an 0.7.x release. This PR bumps the core library and the exporter to 0.7.1 so we can release them together.

@reyang I think this is the most consistent way to version the packages even though it means changing the version number of the core library without any changes.

@c24t c24t requested a review from reyang August 5, 2019 20:53
@c24t c24t requested review from songy23 and a team as code owners August 5, 2019 20:53
@reyang
Copy link
Contributor

reyang commented Aug 5, 2019

@c24t I prefer to keep openceusus 0.7.0 and use 0.7.1 for StackDriver exporter. While I don't have strong objection on updating opencensus to 0.7.1 even if there is no code changes, feel free to decide.

@c24t
Copy link
Member Author

c24t commented Aug 5, 2019

We can pick up #738 in this release too since it's a non-breaking change, it just missed the 0.7.0 release.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 5, 2019
@c24t c24t added cla: yes and removed cla: no labels Aug 5, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@c24t
Copy link
Member Author

c24t commented Aug 5, 2019

We got confirmation from @victoraugustolls in #738.

@@ -5,8 +5,9 @@
## 0.7.0
Released 2019-07-31

- Updated span attributes to include some missing attributes listed [here](https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/HTTP.md#attributes)
([#735](https://github.com/census-instrumentation/opencensus-python/pull/735))
- Updated span attributes to include some missing attributes listed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update version files for these extensions: opencensus-ext-django, opencensus-ext-flask, opencensus-ext-jaeger, opencensus-ext-ocagent, opencensus-ext-pymongo.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 5, 2019
@c24t c24t added cla: yes and removed cla: no labels Aug 5, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@c24t c24t merged commit 7395e37 into census-instrumentation:v0.7.x Aug 6, 2019
@c24t c24t deleted the v0.7.1 branch August 6, 2019 00:13
@c24t c24t mentioned this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants