Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codeowners file #756

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Update codeowners file #756

merged 2 commits into from
Aug 7, 2019

Conversation

reyang
Copy link
Contributor

@reyang reyang commented Aug 7, 2019 •
edited
Loading

  1. Propose to add @victoraugustolls as the owner. Victor has expressed strong interest and commitment in OpenCensus and OpenTelemetry Python SDKs. He has contributed Support server performance breakdown by operation name #735, Added set_status to span, updated pymongo integration #738, Requests library spec fidelity #746 and Hotfix/django flask pyramid status code #755, the code quality is excellent!
  2. Add @lzchen as the owner for opencensus-ext-azure package. @lzchen is the full time employee of Microsoft working on OpenCensus/OpenTelemetry Python SDKs and the integration with Azure.

Please let me know if you have any objections.

@reyang reyang requested review from c24t, songy23 and a team as code owners August 7, 2019 06:00
@reyang reyang requested a review from lzchen August 7, 2019 06:00
@timgraham
Copy link
Contributor

I was contracted to make some contributions to opencensus-ext-django. I don't anticipate my ongoing involvement as I don't use the project personally.

@reyang
Copy link
Contributor Author

reyang commented Aug 7, 2019

I was contracted to make some contributions to opencensus-ext-django. I don't anticipate my ongoing involvement as I don't use the project personally.

Got it, I'll remove you from the owners list. Thanks.

songy23
songy23 approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see more people participating :)

c24t
c24t approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoraugustolls if it LGTY it LGTM.

@victoraugustolls
Copy link
Contributor

victoraugustolls commented Aug 7, 2019 •
edited
Loading

LGTM! Happy to help!

@reyang reyang merged commit 577fb61 into master Aug 7, 2019
@reyang reyang deleted the owners branch August 20, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

@songy23 songy23 songy23 approved these changes

@lzchen lzchen Awaiting requested review from lzchen lzchen is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reyang @timgraham @victoraugustolls @songy23 @c24t @googlebot