Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Update readme, add contributing guide & changelog #43

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

draffensperger
Copy link
Contributor

The usage instructions will continue to evolve as the library matures, but this is a decent start.

@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          25       25           
  Lines         557      557           
  Branches       69       69           
=======================================
  Hits          540      540           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02eff2...d9e474c. Read the comment docs.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor nits

README.md Outdated
application performance and behavior monitoring data. This library currently
generates traces for the initial page load of a site in the browser. It supports
sending the trace sampling decision and trace ID from the web server to the
browser client to enable latency debuging across the stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/debuging/debugging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

README.md Outdated
useful for experimentation with the library but is not appropriate for a real
application.

OpenCensus Web also supports connecting the server side spand for the initial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: spand?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, "spans"

README.md Outdated
opencensus libraries, then there is no deprecation period. Otherwise, we will deprecate it for 18
months before removing it, if possible.

**Alpha**: Libraries defined at a Alpha quality level can be unstable and could cause crashes or data loss. Alpha software may not contain all of the features that are planned for the final version. The API is subject to change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/a Alpha/an Alpha?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@draffensperger draffensperger merged commit 3bb31f0 into master Apr 15, 2019
@draffensperger draffensperger deleted the readme-updates branch April 15, 2019 12:27
RenaultAI pushed a commit to RenaultAI/opencensus-web that referenced this pull request Nov 20, 2019
Add multiplexing/"pass through" mode where spans from
sources other than the initiating node can be sent
and they should be properly proxied to their final
destination. If the currently received node is nil,
use the previously received and non-nil node, and after
processing spans, memoize the last received node.
Updated the tests to lock-in this behavior.

This change also adds in tests to ensure this behavior
and to avoid regressions in the future.

Fixes census-instrumentation#43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants