Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch is a prerequisite and other suggestions #16

Closed
purpleinfinity opened this issue Dec 24, 2013 · 1 comment
Closed

patch is a prerequisite and other suggestions #16

purpleinfinity opened this issue Dec 24, 2013 · 1 comment

Comments

@purpleinfinity
Copy link

Thanks for your work!

I ran the scripts on a CentOS 6.5 VM built from the "minimal.iso".
This revealed that the "patch" RPM is also a prerequisite to success in addition to "git", "wget", "unzip", and a Java installation.

Also, your script does not detect that the patch command is missing, skips over applying the patches, and goes ahead and launches the Maven build.

A useful comment to add to the readme would be a hint to do a "tail -f ./eap-build/work/build.log" once the script launches the Maven build. Otherwise, many minutes of quiet anticipation ensue.

Suggestion for enhancement: It would be great if one could specify both the baseline version of EAP as well as a specific full path to the patch file. In my case, I'm editing the patch file to advance to the most recent minor version of the patched dependencies instead of falling back to the last closest. Since I don't know what Redhat is hiding and what we are missing, figured there is a chance that upstream of those dependencies contain the fixes in later versions.

@hasalex
Copy link
Collaborator

hasalex commented Dec 25, 2013

Thanks for the feedback. A lot of good thinks to add.
BTW, PR are welcome ;)

hasalex added a commit that referenced this issue Dec 31, 2013
@hasalex hasalex closed this as completed Dec 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants