-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new micro plans #125
add new micro plans #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a review focusing on the documentation; didn't review/comment heavily on code except to note places where we've checked in binary files that should be removed, gitignored, and built in the github action instead.
micro_emulation_plans/src/reflective_loading/reflective_loading.zip
Outdated
Show resolved
Hide resolved
...s/src/user_execution/dot_one/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs
Outdated
Show resolved
Hide resolved
- Application: Microsoft Visual Studio | ||
|
||
1. Use [this cyberchef link](https://gchq.github.io/CyberChef/#recipe=Encode_text('UTF-16LE%20(1200)')To_Base64('A-Za-z0-9%2B/%3D')&input=c2NodGFza3MgL0NyZWF0ZSAvRiAvU0MgTUlOVVRFIC9NTyAzIC9TVCAwNzowMCAvVE4gQ01EVGVzdFRhc2sgL1RSICJjbWQgL2MgZGF0ZSAvVCA%2BIEM6XFdpbmRvd3NcVGVtcFxjdXJyZW50X2RhdGUudHh0Ig), replacing the `input` with the desired PowerShell commands | ||
2. Paste the `output` from CyberChef into a new file `README.md` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking the instructions here. A "new" README.md will overwrite the existing one. Might be easier to explain that you edit README.md and replace the contents with the new b64 string?
Also is it really necessary (I'm not sure how VS handles resources) to edit Resource1.resx if the new README has the same name as the oldone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed phrasing to make a little more clear. I haven't tested just replacing the file or overwriting it in the folder and then building but afaik that should not post any issues
Added some comments above; also note that the windows build is failing with several errors like this:
We had the same issue with the last transfer from private repo to public. The added path component |
removed codev badge, changed 'micro emulation plans' to h2 header, fixed 'emulate/s' mismatch, removed errant backtick, fixed relative url,
Fixed TA008 link
These resources are not part of micro plans so i'm not sure how the @mehaase i could use some extra help on this |
Oh, good point. Maybe when we run nuget restore, it’s running for all the plans? I’m on mobile atm but we could look at the build logs to find out. |
I checked the build logs and its failing while checking out our repo. That's weird because this same repo was running fine recently, right? I don't know what changed. We should nuke this whole |
No description provided.