-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TypeScript strict mode #619
Comments
@seancolsen Sounds good to me, we can enable strict. We can consider disabling specific rules if we run into issues in the future. |
We made some progress towards this ticket in #826 but there's still quite a bit more work to do cleaning up errors before we can turn on strict mode. It's a little hard do imagine finding the time to prioritize that clean-up work before our Alpha release. Also, I'm noticing new code that will add more type errors once we turn on strict mode, so we might find ourselves chasing a moving target to some extent. @pavish As a stopgap measure to address the "moving target" problem, I'm wondering how you would feel about the following approach, going forward:
|
@seancolsen I think this approach sounds good. Let's move forward with it. |
Description
strictNullChecks are currently not enabled, as they tend to increase boilerplate condition checks. It may lead to the code getting more verbose and being forced to check
null
andundefined
, when we know for certain those values will not occur in certain scenarios.However, considering that our contributors would be working on small improvements, it is better to have it enabled to avoid unforeseen bugs. The trade-off seems worth it.
The text was updated successfully, but these errors were encountered: