-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept type_options when testing type casts, making it possible to test every type cast #869
Comments
Hi, I would like to help in this problem. |
@jjram20 Thanks! I have assigned it to you. |
@jjram20 Hey, are you still making progress on this issue? |
Unassigning due to lack of progress / feedback. |
Hi, I'd like to work on this issue. |
Sure, go ahead @Jayitha |
Hi, Sorry for the delay, I spent some time playing around with the codebase. I think the whole types system is pretty neat! especially how it renders in Postgres. I created a PR for this issue to get things going. I currently only included support to provide type options for the target type. I'd actually like to work on this issue in tandem with #1138 if possible? |
Sure @Jayitha, that shouldn't be a problem |
This issue has not been updated in 90 days and is being marked as stale. |
We should avoid doing this until we've moved the type casting functions to the DB, and then also the type casting test suite. |
Problem
Currently, test case fixture(db/tests/types/operations/test_cast.py:MASTER_DB_TYPE_MAP_SPEC) used to test casting of a column type do not seem to accept type options, so this makes it not possible to test certain type casts like
URI
toCHAR
(CHAR without type_options defaults to 1 character), making the test cases incomplete.Proposed solution
TARGET_DICT
dictionary should accepttype_options
for each type.The text was updated successfully, but these errors were encountered: