Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Inference 4: Set best types for columns of table #94

Closed
mathemancer opened this issue May 3, 2021 · 1 comment · Fixed by #139
Closed

Type Inference 4: Set best types for columns of table #94

mathemancer opened this issue May 3, 2021 · 1 comment · Fixed by #139
Assignees
Labels
type: enhancement New feature or request

Comments

@mathemancer
Copy link
Contributor

Problem

Different types in Mathesar will enable different operations; for example, strings could be aggregated by concatenating, but numeric types could be aggregated by summing or multiplying. So far, while we can reflect different types, we have no way to determine the type most appropriate for a table.

Proposed solution

Using the functions from #91 , #92 , and #93 , we should make a function that takes a schema, original_table_name, and new_table_name, creates a new table with typed columns of the same names as the old table, and inserts all data there. The old table can be optionally dropped.

@mathemancer mathemancer added the type: enhancement New feature or request label May 3, 2021
@kgodey
Copy link
Contributor

kgodey commented May 3, 2021

This should not directly take the output of #93, since types need to be verified manually by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants