This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(api): Resource::list return empty list if the regex is not valid #8437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorvassilev
previously approved these changes
Mar 20, 2020
callapa
suggested changes
Mar 20, 2020
| ->findResources($filter); | ||
| } catch (\PDOException $e) { | ||
| if ($e->getCode() !== "42000") { | ||
| throw $e; |
There was a problem hiding this comment.
The controller must not be aware of structure exceptions.
PDO is a class to read data so it's not a business class.
There was a problem hiding this comment.
Your repository can raised a specific exception that will can be catch by the service
There was a problem hiding this comment.
could you give an example from the existing code base, because the idea isn't to change the behavior that we have already just to avoid the particular problem described in the PR
Resolve MON-5034
…erviceInterface ERROR: Call to an undefined method Centreon\Domain\Monitoring\Interfaces\ResourceServiceInterface::filterByContact() Resolve MON-5034
Resolve MON-5034
…face Resolve MON-5034
Resolve MON-5034
Resolve MON-5034
Resolve MON-5034
victorvassilev
previously approved these changes
Mar 20, 2020
callapa
suggested changes
Mar 23, 2020
| @@ -48,7 +48,7 @@ | |||
| final class ResourceRepositoryRDB extends AbstractRepositoryDRB implements ResourceRepositoryInterface | |||
| { | |||
| /** | |||
| * @var AccessGroup[] List of access group used to filter the requests | |||
| * @var AccessGroup[]|null List of access group used to filter the requests | |||
There was a problem hiding this comment.
List can be emty, not null
vhr
commented
Mar 23, 2020
src/Centreon/Infrastructure/RequestParameters/SqlRequestParametersTranslator.php
Outdated
Show resolved
Hide resolved
vhr
commented
Mar 23, 2020
victorvassilev
previously approved these changes
Mar 24, 2020
callapa
reviewed
Mar 24, 2020
Co-Authored-By: Laurent Calvet <lcalvet@centreon.com>
callapa
reviewed
Mar 24, 2020
src/Centreon/Infrastructure/RequestParameters/SqlRequestParametersTranslator.php
Outdated
Show resolved
Hide resolved
…tersTranslator.php
callapa
approved these changes
Mar 24, 2020
victorvassilev
approved these changes
Mar 24, 2020
Closed
17 tasks
This was referenced Aug 12, 2020
This was referenced Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when the user sends invalid regexp to with operator $rg server will throw an exception from the DB,
the idea is to return empty list
related PR https://github.com/centreon/centreon/pull/8432
Fixes MON-5034
Type of change
Target serie
How this pull request can be tested ?
send GET request to http://localhost/centreon/api/beta/monitoring/resources?page=1&limit=100&search={%22$or%22:[{%22name%22:{%22$rg%22:%22a%22}}]}
Checklist
Community contributors & Centreon team
Centreon team only