Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ns-header] add Guidance image and Key #677

Conversation

RobTobias123
Copy link
Contributor

No description provided.

@RobTobias123 RobTobias123 changed the base branch from main to epic/converted-guidance-images July 23, 2024 11:19
Copy link

cloudflare-workers-and-pages bot commented Jul 23, 2024

Deploying nucleus-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: cebdd32
Status: ✅  Deploy successful!
Preview URL: https://cd504cdd.nucleus-docs.pages.dev
Branch Preview URL: https://chore-add-header-guidance-im.nucleus-docs.pages.dev

View logs

Copy link
Contributor

@andij andij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be added?

To me the content in the Key is closely replicating the information in the Specification.

Check with the team to agree on outcome.

@RobTobias123
Copy link
Contributor Author

I felt itwasn't that clear which part was called what, and so to avoid keep switching between live examples to understand I thought adding the labelled diagram might help describe with content that is consistent with other components pages. Happy to discuss further with team to ascertain.

@andij andij changed the title Added guidance webp and key for labels [ns-header] add Guidance image and Key Aug 7, 2024
@RobTobias123
Copy link
Contributor Author

Closing with no changes as decided out of scope for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants