github: add syntax and lint checks #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akraitman
reviewed
Apr 24, 2023
akraitman
previously approved these changes
Apr 24, 2023
Run Ansible's syntax checks and ansible-lint on every PR and Git push. Ignore some common ansible-lint errors so we can get to green quickly. We can re-evaluate this list later and perhaps fix some of them down the road.
caught with ansible-lint
ansible-lint cannot load tasks with these longer parent paths. load-failure: [Errno 2] No such file or directory (filenotfounderror)
Instead of skipping ansible-lint's no-tabs rule globally, apply it on this single task that uses a tab (\t) character. Longer-term, we could replace this tab with a space because /etc/hosts can use either whitespace character. I'm taking a cautious approach today for simplicity.
akraitman
approved these changes
Apr 25, 2023
dmick
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Ansible's
--syntax-checkandansible-linton every PR and Git push.Ignore some common
ansible-linterrors so we can get to green quickly. We can re-evaluate this list later and perhaps fix some of them down the road.