-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mon: remove key generation #1238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This is for N and above only so we need to add an exception for L and M. |
leseb
commented
Nov 15, 2018
ErwanAliasr1
suggested changes
Nov 16, 2018
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 16, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 16, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
ErwanAliasr1
suggested changes
Nov 16, 2018
@leseb Looks like we are ready to merge isn't it ? |
As for Nautilus, keys get automatically generated so we don't need to create them during the initial bootstrap. We still keep the ability to generate our how admin key though. Signed-off-by: Sébastien Han <seb@redhat.com>
Since Nautilus keys are generated by the mon itself, we just need to fetch them on the filesystem with the initial mon. key. The demo file is kept intact for luminous & mimic Signed-off-by: Sébastien Han <seb@redhat.com> Signed-off-by: Erwan Velu <erwan@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 23, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 26, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 27, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 28, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Nov 30, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Dec 2, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Dec 3, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Dec 3, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Dec 3, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to ceph/ceph-ansible
that referenced
this pull request
Dec 3, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Dec 3, 2018
This commit unifies the container and non-container code, which in the meantime gives use the ability to deploy N mon container at the same time without having to serialized the deployment. This will drastically reduces the time needed to bootstrap the cluster. Note, this is only possible since Nautilus because the monitors are bootstrap the initial keys on their own once they reach quorum. In the Nautilus version of the ceph-container mon, we stopped generating the keys 'manually' from inside the container, for more detail see: ceph/ceph-container#1238 Signed-off-by: Sébastien Han <seb@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for Nautilus, keys get automatically generated so we don't need to
create them during the initial bootstrap.
We still keep the ability to generate our how admin key though.
Signed-off-by: Sébastien Han seb@redhat.com