Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why a deepcopy here? afaik, client.Get fills in the memory that we supply and this is already a copy. #58

Open
Madhu-1 opened this issue Jul 26, 2024 · 5 comments · May be fixed by #155
Labels
wontfix This will not be worked on

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 26, 2024

          why a deepcopy here? afaik, `client.Get` fills in the memory that we supply and this is already a copy.

Originally posted by @leelavg in #24 (comment)

@nb-ohad
Copy link
Collaborator

nb-ohad commented Jul 29, 2024

To the best of my understanding, this is true only if your struct does not have pointers. In the case of a pointer, the pointer gets copied (which means the underlying value is shared).
If we can prove that this is not the case and that Get creates a deep clone then we can remove our own deep clone operation

@leelavg
Copy link
Contributor

leelavg commented Jul 30, 2024

Already looked at #24 (comment)?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jul 30, 2024

@leelavg is this already sorted out and can be closed?

@leelavg
Copy link
Contributor

leelavg commented Jul 30, 2024

Not solved.

@leelavg leelavg linked a pull request Oct 15, 2024 that will close this issue
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants