Migrate away from pycrypto?

[smithfarm]

Hi. I noticed that ceph-iscsi has a runtime dependency on pycrypto 2.6.1 [1]

This is problematic for openSUSE because this package has been removed from the distribution. It is slated to be dropped from SLES as well, though that has not happened just yet.

Apparently, this package is only used here:

ceph-iscsi/ceph_iscsi_config/client.py

Line 3 in c6860ae

from Crypto.PublicKey import RSA

The openSUSE maintainers suggest that we migrate to https://pypi.org/project/pycryptodomex/ or https://pypi.org/project/pyOpenSSL/ - is this feasible?

[1] https://www.dlitz.net/software/pycrypto/

[dillaman]

I'd vote for pyOpenSSL since Ceph already has a dependency on it.

[rjfd]

@dillaman @smithfarm the pyOpenSSL only works for managing keys/certificates it does not have the encrypt/decrypt function that it's required by the ceph-iscsi code.

In the the pyOpenSSL documentation they recommend the usage of python-cryptography package to preform encrypt/decrypt (https://pyopenssl.org/en/stable/api/crypto.html#module-OpenSSL.crypto).

Can we use python-cryptography instead?

[smithfarm]

@rjfd Works for me:

SLE-15: python3-cryptography 2.1.4
openSUSE:Factory: python3-cryptography 2.3.1

[dillaman]

That's fine w/ me as well since it's available in RHEL/CentOS