Add "Admin" role #121
Merged
Add "Admin" role #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoasmarques
added
Add To Changelog
smithfarm
reviewed
Mar 11, 2020
smithfarm
reviewed
Mar 11, 2020
Fixes: ceph#71 Signed-off-by: Ricardo Marques <rimarques@suse.com>
ricardoasmarques
force-pushed
the
admin-role
branch
from
fb76676
to
0cb44ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 77.87% 77.93% +0.05%
==========================================
Files 10 10
Lines 2111 2116 +5
==========================================
+ Hits 1644 1649 +5
Misses 467 467
Continue to review full report at Codecov.
|
smithfarm
approved these changes
Mar 11, 2020
This was referenced Mar 12, 2020
ricardoasmarques
removed
the
Add To Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of installing "ceph-tools [1]" on all "Mgr" nodes, we will now install those tools on"Admin" nodes.
Note that "Bootstrap" minion must be an "Admin" node.
[1] ceph.conf, keyring, and ceph-common[2]
[2] ceph-common will be replaced by an alias on #120
Fixes: #71
Signed-off-by: Ricardo Marques rimarques@suse.com