New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: stop MgrClient callbacks on shutdown #14896

Merged
merged 1 commit into from May 2, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented May 1, 2017

Stop the MgrClient callbacks to report PG stats at the
start of shutdown() so that we don't get a callback
during/after we are done shutting down.

Protect the cb update with the MgrClient's lock so that
we don't race with MgrClient::send_report() itself.

Fixes: http://tracker.ceph.com/issues/19638
Signed-off-by: Sage Weil sage@redhat.com

osd: stop MgrClient callbacks on shutdown
Stop the MgrClient callbacks to report PG stats at the
start of shutdown() so that we don't get a callback
during/after we are done shutting down.

Protect the cb update with the MgrClient's lock so that
we don't race with MgrClient::send_report() itself.

Fixes: http://tracker.ceph.com/issues/19638
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from tchaikov May 1, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented May 1, 2017

retest this please

@jdurgin

jdurgin approved these changes May 1, 2017

@liewegas liewegas merged commit 0bded75 into ceph:master May 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-19638 branch May 2, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 2, 2017

i think we should call mgrc.shutdown() earlier, as it has broader dependencies on the OSD daemon itself than other member components (variables) used by OSD.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 2, 2017

posted #14904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment