luminous: doc: Put command template into literal block #25001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrStupnikov i noticed that this change is actually a backport of #24999 . could you do instead a "git cherry-pick -x bff5a21" onto luminous and the repush the fix? we enforce this approach to ensure that the fixes on master are properly populated to supported branches. normally, a tracker ticket is created to make sure the fix are tracked. |
smithfarm
suggested changes
Nov 15, 2018
There was a problem hiding this comment.
missing (cherry-picked from ...) line - see #25001 (comment)
|
@MrStupnikov No tracker ticket is needed in this case, just |
``ceph-deploy osd create --data {device} {ceph-node}`` command
is not displayed properly because of missing double colons.
Signed-off-by: Alexey Stupnikov <aleksey.stupnikov@gmail.com>
(cherry picked from commit bff5a21)
|
@tchaikov @smithfarm thank you for your reviews. Pushed proper commit message. |
smithfarm
approved these changes
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ceph-deploy osd create --data {device} {ceph-node}commandis not displayed properly because of missing double colons. As a result, double en dash is translated to single en dash [1]
[1] http://docs.ceph.com/docs/luminous/start/quick-ceph-deploy/